feat: update tokens from Tokens Studio release - #5280
Conversation
|
@claude review |
|
Claude finished @pomfrida's task in 5m 7s —— View job Review: token release PR
This is not a routine token bump — it's a full replacement of the semantic colour vocabulary. 55 semantic names are removed and ~180 added, plus a new What I verified
🔴 Blocking: one in-repo consumer breaks
.eds-storybook-wrapper {
background-color: var(--eds-background-container-canvas-default); /* ← removed */
}There is no fallback, so the Storybook canvas background silently becomes transparent in both schemes, and nothing in CI fails (unresolved custom properties are not a build error). The replacement is That's the only broken reference — I grepped every package and app; nothing else consumes the removed names. ( 🟠 Silent value changes behind surviving namesThree tokens keep their name but change meaning. Any consumer already on the beta line gets a visual change with no diff signal on their side:
🟠 Worth an explicit changelog rename mapThe beta is on the The 🟡 Light-scheme contrast (pre-existing, not a regression)Computed from the new bundle (oklch → sRGB, WCAG 2.1). Dark scheme passes everything; light scheme has three below AA 4.5:1:
All three carry over unchanged from 🟡 Stale script comments (follow-up, non-blocking)
VerdictGenerated output is correct and reproducible, and it fixes a real bug (the focus-ring self-reference). Fix I have not committed anything — the working tree is clean after my regeneration checks. Say the word if you'd like me to push the |
eddiman
left a comment
There was a problem hiding this comment.
No need for change LGTM. Regarding a11y-issues: We dont use any of those colors on bg-canvas, så claude is dramatic .
Automated pull of the token state after a Tokens Studio release: raw token sets via
studio tokens pull(sources inpackages/eds-tokens/.studio.json), generated CSS (EDS-CSS export) intopackages/eds-tokens/src/tokens/css/, DTCG (EDS-DTCG export) intosrc/tokens/dtcg/, TypeScript modules generated from the two intosrc/tokens/ts/, and the bundledsrc/tokens/css/variables.css(concatenation of the CSS export, per ADR-0010). Thesemantic/*.cssfiles are widened to:root, [data-color-scheme]byscripts/widen-semantic-scope.mjsbefore bundling (#5226) — that selector diff against the raw export is expected.