ci: build when no secret available

[MarcusDragsten]

What does this pull request change?

Why is this pull request needed?

Issues related to this change

[Copilot]

Pull request overview

Updates the CI test workflow to successfully build the API Docker image even when the ACR secret isn’t available (e.g., forks / no secret passed via workflow_call), while still using registry cache when credentials exist.

Changes:

• Adds a conditional in the “Build API image” step to skip ACR login/pull when ACR_SECRET is absent.
• Provides ACR_SECRET via step-level env so the script can safely check for its presence.

Comments suppressed due to low confidence (1)

.github/workflows/tests.yaml:60

• Using echo "$ACR_SECRET" | docker login ... --password-stdin can break if the secret starts with something echo treats as a flag (e.g. -n) or contains backslash escapes. Prefer printf '%s' "$ACR_SECRET" | docker login "$IMAGE_REGISTRY" ... --password-stdin (and quote the vars) to make the login robust.

            echo "$ACR_SECRET" | docker login $IMAGE_REGISTRY -u datamodelingtool --password-stdin
            docker pull $API_IMAGE
            DOCKER_BUILDKIT=1 docker build --target development --tag job-api-development --cache-from $API_IMAGE .

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.