refactor: remove PumpModelDTO and factory, use PumpModel directly

[frodehk]

Why is this pull request needed?

This PR simplifies the pump model architecture in the codebase by removing the obsolete PumpModelDTO data class and related factory logic. By eliminating the DTO layer and directly using PumpModel and its subclasses, the code becomes more maintainable and easier to work with, reducing unnecessary complexity and potential sources of error.

What does this pull request change?

• Removes the PumpModelDTO class and all references to it.
• Deletes the pump/factory.py file which previously handled DTO-based pump creation.
• Updates mapping logic and reference services to use PumpModel, PumpSingleSpeed, and PumpVariableSpeed directly.
• Refactors YAML mappers and associated tests to work with the new structure.

[Copilot]

Pull Request Overview

This PR refactors the pump model architecture by removing the obsolete PumpModelDTO layer and directly using PumpModel classes throughout the codebase.

• Eliminates PumpModelDTO data class and associated factory logic
• Updates mapper functions to directly instantiate PumpSingleSpeed and PumpVariableSpeed classes
• Removes the pump/factory.py file and its create_pump_model function

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/libecalc/input/mappers/test_consumer_chart.py	Updates test assertions to work with PumpModel instances instead of PumpModelDTO
src/libecalc/presentation/yaml/yaml_entities.py	Changes type annotation and isinstance check from PumpModelDTO to PumpModel
src/libecalc/presentation/yaml/mappers/facility_input.py	Refactors mapper functions to directly instantiate PumpSingleSpeed/PumpVariableSpeed with proper chart wrapping
src/libecalc/presentation/yaml/mappers/consumer_function_mapper.py	Removes factory import and direct create_pump_model calls
src/libecalc/presentation/yaml/domain/reference_service.py	Updates type annotations from PumpModelDTO to PumpModel
src/libecalc/domain/process/pump/pump.py	Removes PumpModelDTO class definition
src/libecalc/domain/process/pump/factory.py	Deletes entire factory file with pump creation logic

Comments suppressed due to low confidence (1)

src/libecalc/presentation/yaml/mappers/facility_input.py:1

• The arguments to InvalidConsumptionType are reversed. The 'actual' parameter should receive the 'consumes' value, and 'expected' should receive ConsumptionType.ELECTRICITY.

from typing import Union

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}