chore: init recirculation pressure control#1364
Conversation
jsolaas
force-pushed
the
chore/init-recirc
branch
5 times, most recently
from
5386f34 to
bc542a8
Compare
jsolaas
force-pushed
the
chore/init-recirc
branch
from
bc542a8 to
737e7c8
Compare
| boundary=Boundary(min=minimum_rate, max=maximum_rate), | ||
| func=lambda x: get_outlet_stream(recirculation_rate=x).pressure_bara - target_pressure, | ||
| ) | ||
| return get_outlet_stream(recirculation_rate=recirculation_rate) |
There was a problem hiding this comment.
So, possibly let the solver return a "solution" instead (or NO_SOLUTION if none, but I guess in that case we want to throw an exception? Might be that we ahve several strategies that we try, and we dont know that the search for a solution is exhaustive, until we reach this point?)
RecirculationSolverSolution(SUCCESS, RecirculationLoopConfiguration(recirculation_rate=nn)) ?
There was a problem hiding this comment.
in that case, it is important that we work on immutable objects, or immutable methods, where we just "test a solution"; which is different from the actual process, that does manipulate the actual stream?
| boundary=Boundary(min=minimum_rate, max=maximum_rate), | ||
| func=lambda x: get_outlet_stream(recirculation_rate=x).pressure_bara - target_pressure, | ||
| ) | ||
| return get_outlet_stream(recirculation_rate=recirculation_rate) |
There was a problem hiding this comment.
in that case, it is important that we work on immutable objects, or immutable methods, where we just "test a solution"; which is different from the actual process, that does manipulate the actual stream?
| def __init__(self, boundary: Boundary, target_pressure: float, shaft: Shaft): | ||
| def __init__( | ||
| self, | ||
| search_strategy: SearchStrategy, |
There was a problem hiding this comment.
nice separation. Could they be "combined"? Does user need to know nitty gritty details?
2 participants
No description provided.