Skip to content

refactor: make temperature setter inherit from ProcessUnit#1373

Merged
olelod merged 1 commit intomainfrom
refactor/temperature-setter-inherit-from-processunit
Feb 4, 2026
Merged

refactor: make temperature setter inherit from ProcessUnit#1373
olelod merged 1 commit intomainfrom
refactor/temperature-setter-inherit-from-processunit

Conversation

@olelod
Copy link
Copy Markdown
Contributor

@olelod olelod commented Feb 4, 2026

Type of Work

  • Patch: X.Y.Z+1. NEGLIGIBLE visible changes, does not change input or output - OR changes behaviour. Use chore:, refactor: etc
  • Minor: X.Y+1.Z. Minor changes, might ADD new input (YAML), or other backwards-compatible changes. Use feat:, fix:
  • Major: X+1.Y.Z. Major and most likely BREAKING changes, wo. backwards compatibility, or removing temporary backwards compatibility functionality. Use ! or BREAKING:.

See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044

Have you remembered and considered?

  • IF FEAT: I have remembered to update documentation
  • IF FIX OR FEAT: I have remembered to update manual changelog (docs/drafts/next.draft.md)
  • IF BREAKING: I have remembered to update migration guide (docs/docs/migration_guides/)
  • IF BREAKING: I have committed with BREAKING: in footer or ! in header
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Github issue nr in the footer!

What is this PR all about?

What else did you consider?

Between the lines?

@olelod olelod requested a review from a team as a code owner February 4, 2026 09:32
Comment thread tests/libecalc/domain/process/test_process_solver.py
@olelod olelod force-pushed the refactor/temperature-setter-inherit-from-processunit branch from 82e5edd to 513889f Compare February 4, 2026 10:31
@olelod olelod merged commit 6b847cf into main Feb 4, 2026
22 checks passed
@olelod olelod deleted the refactor/temperature-setter-inherit-from-processunit branch February 4, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants