Skip to content

refactor: configuration solvers#1383

Merged
jsolaas merged 1 commit intomainfrom
refactor/configuration-solvers
Feb 11, 2026
Merged

refactor: configuration solvers#1383
jsolaas merged 1 commit intomainfrom
refactor/configuration-solvers

Conversation

@jsolaas
Copy link
Copy Markdown
Contributor

@jsolaas jsolaas commented Feb 10, 2026

No description provided.

@jsolaas jsolaas force-pushed the refactor/configuration-solvers branch from 6c3a31f to 2cccc7f Compare February 10, 2026 13:20
@jsolaas jsolaas changed the title refactor/configuration solvers refactor: don't manipulate fluids in upstream choke solver Feb 10, 2026
@jsolaas jsolaas changed the title refactor: don't manipulate fluids in upstream choke solver refactor: configuration solvers Feb 10, 2026
@jsolaas jsolaas force-pushed the refactor/configuration-solvers branch from 2cccc7f to 3dd9d0a Compare February 10, 2026 14:20
@jsolaas jsolaas marked this pull request as ready for review February 10, 2026 14:20
@jsolaas jsolaas requested a review from a team as a code owner February 10, 2026 14:20
@jsolaas jsolaas force-pushed the refactor/configuration-solvers branch 2 times, most recently from 916868d to d077f09 Compare February 11, 2026 07:53
Use a separate configuration in solvers to separate solver from
ProcessSystem. This will also make it possible to combine solvers
without each solver knowing about it. I.e. recirculation can be used
when testing a speed-configuration.
@jsolaas jsolaas force-pushed the refactor/configuration-solvers branch from d077f09 to 5ba14d1 Compare February 11, 2026 08:05
@jsolaas jsolaas merged commit 5bf15db into main Feb 11, 2026
38 of 39 checks passed
@jsolaas jsolaas deleted the refactor/configuration-solvers branch February 11, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants