Skip to content

ci: add ISC license to allowed licenses in workflow#1389

Merged
tj098895 merged 2 commits intomainfrom
tj098895-patch-2
Feb 17, 2026
Merged

ci: add ISC license to allowed licenses in workflow#1389
tj098895 merged 2 commits intomainfrom
tj098895-patch-2

Conversation

@tj098895
Copy link
Copy Markdown
Contributor

adding ISC license, since we have a package that has that license, and it is compatible with LGPL 3.0

Type of Work

  • Patch: X.Y.Z+1. NEGLIGIBLE visible changes, does not change input or output - OR changes behaviour. Use chore:, refactor: etc
  • Minor: X.Y+1.Z. Minor changes, might ADD new input (YAML), or other backwards-compatible changes. Use feat:, fix:
  • Major: X+1.Y.Z. Major and most likely BREAKING changes, wo. backwards compatibility, or removing temporary backwards compatibility functionality. Use ! or BREAKING:.

See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044

Have you remembered and considered?

  • IF FEAT: I have remembered to update documentation
  • IF FIX OR FEAT: I have remembered to update manual changelog (docs/drafts/next.draft.md)
  • IF BREAKING: I have remembered to update migration guide (docs/docs/migration_guides/)
  • IF BREAKING: I have committed with BREAKING: in footer or ! in header
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Github issue nr in the footer!

What is this PR all about?

What else did you consider?

Between the lines?

adding ISC license, since we have a package that has that license, and it is compatible with LGPL 3.0
@tj098895 tj098895 requested a review from a team as a code owner February 17, 2026 11:57
Removed trailing comma from allowed licenses in license-scan.yml.
@tj098895 tj098895 merged commit ff61be7 into main Feb 17, 2026
22 checks passed
@tj098895 tj098895 deleted the tj098895-patch-2 branch February 17, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants