feat: introduce single-stream ProcessUnit variants of Mixer and Splitter#1449
Merged
feat: introduce single-stream ProcessUnit variants of Mixer and Splitter#1449
Conversation
olelod
force-pushed
the
refactor/mixers-and-splitters-v2
branch
2 times, most recently
from
b7656d0 to
4225c7c
Compare
This was referenced Mar 19, 2026
jsolaas
approved these changes
Mar 23, 2026
…ocessUnit variants - Rename Mixer → LegacyMixer (mixer/mixer.py → legacy_mixer/legacy_mixer.py) - Rename Splitter → LegacySplitter (splitter/splitter.py → legacy_splitter/legacy_splitter.py) - Introduce Mixer(ProcessUnit) in process_units/mixer.py: adds one external stream to a through-stream - Introduce Splitter(ProcessUnit) in process_units/splitter.py: removes a fixed rate from a through-stream - Add tests for new Mixer and Splitter
olelod
force-pushed
the
refactor/mixers-and-splitters-v2
branch
from
4225c7c to
3f089e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If several streams enter between two stages, there will be one mixer for each of them. Same with splitters, if several streams/rates leave between two stages.
Type of Work
See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044
Have you remembered and considered?
docs/drafts/next.draft.md)docs/docs/migration_guides/)BREAKING:in footer or!in headerWhat is this PR all about?
What else did you consider?
Between the lines?