Skip to content

refactor: add get_configuration to Solution#1459

Merged
olelod merged 1 commit intomainfrom
feat/solution-get-configuration
Mar 26, 2026
Merged

refactor: add get_configuration to Solution#1459
olelod merged 1 commit intomainfrom
feat/solution-get-configuration

Conversation

@olelod
Copy link
Copy Markdown
Contributor

@olelod olelod commented Mar 26, 2026

refactor: extract Configuration and SimulationUnitId from ProcessRunner to break import cycle

Type of Work

  • Patch: X.Y.Z+1. NEGLIGIBLE visible changes, does not change input or output - OR changes behaviour. Use chore:, refactor: etc
  • Minor: X.Y+1.Z. Minor changes, might ADD new input (YAML), or other backwards-compatible changes. Use feat:, fix:
  • Major: X+1.Y.Z. Major and most likely BREAKING changes, wo. backwards compatibility, or removing temporary backwards compatibility functionality. Use ! or BREAKING:.

See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044

Have you remembered and considered?

  • IF FEAT: I have remembered to update documentation
  • IF FIX OR FEAT: I have remembered to update manual changelog (docs/drafts/next.draft.md)
  • IF BREAKING: I have remembered to update migration guide (docs/docs/migration_guides/)
  • IF BREAKING: I have committed with BREAKING: in footer or ! in header
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Github issue nr in the footer!

What is this PR all about?

What else did you consider?

Between the lines?

@olelod olelod requested a review from a team as a code owner March 26, 2026 09:50
@olelod olelod force-pushed the feat/solution-get-configuration branch 3 times, most recently from a05a93c to 1183c3c Compare March 26, 2026 11:21
refactor: extract Configurations and SimulationUnitId from ProcessRunner to break import cycle

refactor: introduce OpertaingConfiguration as union of speed-, choke-, and recircconfigurations
@olelod olelod force-pushed the feat/solution-get-configuration branch from 1183c3c to 6c06707 Compare March 26, 2026 11:23
@olelod olelod merged commit ec7c355 into main Mar 26, 2026
24 checks passed
@olelod olelod deleted the feat/solution-get-configuration branch March 26, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants