Skip to content

refactor: separate process definitions from instance references - #1717

Closed
frodehk wants to merge 5 commits into
mainfrom
refactor/process-yaml-reference-resolution
Closed

refactor: separate process definitions from instance references#1717
frodehk wants to merge 5 commits into
mainfrom
refactor/process-yaml-reference-resolution

Conversation

@frodehk

@frodehk frodehk commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Separates process instance names, instance references, and definition references.
  • Renames reusable sections to PROCESS_UNIT_DEFINITIONS and PROCESS_PIPELINE_DEFINITIONS.
  • Renames pipeline ITEMS to PROCESS_UNITS.
  • Requires explicit pipeline instance names.
  • Adds ProcessUnitResolver and resolver test coverage.

Motivation

This is a first step toward resolving YAML references before domain mapping, with reusable definitions and local instances represented explicitly.


Type of Work

  • Patch: X.Y.Z+1. NEGLIGIBLE visible changes, does not change input or output - OR changes behaviour. Use chore:, refactor: etc
  • Minor: X.Y+1.Z. Minor changes, might ADD new input (YAML), or other backwards-compatible changes. Use feat:, fix:
  • Major: X+1.Y.Z. Major and most likely BREAKING changes, wo. backwards compatibility, or removing temporary backwards compatibility functionality. Use ! or BREAKING:.

See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044

Have you remembered and considered?

  • IF FEAT: I have remembered to update documentation
  • IF FIX OR FEAT: I have remembered to update manual changelog (docs/drafts/next.draft.md)
  • IF BREAKING: I have remembered to update migration guide (docs/docs/migration_guides/)
  • IF BREAKING: I have committed with BREAKING: in footer or ! in header
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Github issue nr in the footer!

What is this PR all about?

What else did you consider?

Between the lines?

@frodehk frodehk self-assigned this Aug 13, 2026
@frodehk
frodehk requested a review from a team as a code owner August 13, 2026 07:32
@frodehk
frodehk marked this pull request as draft August 13, 2026 07:32
@tj098895

Copy link
Copy Markdown
Contributor

isnt this conflicting with #1716 ? Or is the intent to build on top of it?

@frodehk

frodehk commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

isnt this conflicting with #1716 ? Or is the intent to build on top of it?

Yes it is quite similar, we agreed to upload both branches to compare. We are in dialogue:-)

There are some few differences, e.g. handling of pipeline instances and how pipeline objects can be re-used.

@frodehk
frodehk force-pushed the refactor/process-yaml-reference-resolution branch from 1c0450f to 32a64a2 Compare August 13, 2026 09:39
@frodehk

frodehk commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

replaced by: #1716

@frodehk frodehk closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants