refactor: separate process definitions from instance references - #1717
Closed
frodehk wants to merge 5 commits into
Closed
refactor: separate process definitions from instance references#1717frodehk wants to merge 5 commits into
frodehk wants to merge 5 commits into
Conversation
Contributor
|
isnt this conflicting with #1716 ? Or is the intent to build on top of it? |
Contributor
Author
Yes it is quite similar, we agreed to upload both branches to compare. We are in dialogue:-) There are some few differences, e.g. handling of pipeline instances and how pipeline objects can be re-used. |
frodehk
force-pushed
the
refactor/process-yaml-reference-resolution
branch
from
August 13, 2026 09:39
1c0450f to
32a64a2
Compare
Contributor
Author
|
replaced by: #1716 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROCESS_UNIT_DEFINITIONSandPROCESS_PIPELINE_DEFINITIONS.ITEMStoPROCESS_UNITS.ProcessUnitResolverand resolver test coverage.Motivation
This is a first step toward resolving YAML references before domain mapping, with reusable definitions and local instances represented explicitly.
Type of Work
See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044
Have you remembered and considered?
docs/drafts/next.draft.md)docs/docs/migration_guides/)BREAKING:in footer or!in headerWhat is this PR all about?
What else did you consider?
Between the lines?