Validate pressures before computing pressure ratios in simplified compressor train - #1719
Open
olelod wants to merge 1 commit into
Open
Validate pressures before computing pressure ratios in simplified compressor train#1719olelod wants to merge 1 commit into
olelod wants to merge 1 commit into
Conversation
frodehk
approved these changes
Aug 19, 2026
…d train Move validate_pressures() call before create_compressor_model() to prevent divide-by-zero warning when suction pressure is zero. The validation error was already raised, but after the division had already been attempted.
olelod
force-pushed
the
fix/validate-suction-pressure-before-division
branch
from
August 19, 2026 15:03
539b843 to
9acf1ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
SUCTION_PRESSUREis set to 0, aRuntimeWarning: divide by zerois emitted before the validation catches the invalid input. This happens becausevalidate_pressures()is called aftercreate_compressor_model(), which internally computesdischarge_pressure / suction_pressure.