fix: prevent infinite loop in common ASV single-speed solver - #1721
Merged
Conversation
jsolaas
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no mass rate in the [min, max] range produces constant ASV-corrected mass rates across all stages, the
while-loop incrementedincpast 1.0 without ever exiting — logging an error on every iteration indefinitely.Now returns the result at the original un-recirculated mass rate (
minimum_mass_rate_kg_per_hour), which is reported with the appropriate failure status (e.g.BELOW_MINIMUM_FLOW_RATEor target pressure mismatch).This is legacy code only — the new process simulation solver uses bounded bisection (
Bisectwithmax_iterations=20).