fix: error message when no overlapping periods - #1723
Merged
Conversation
Aleksander-Karlsson
approved these changes
Aug 19, 2026
Co-authored-by: Aleksander Karlsson <AMKA@equinor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the compare/delta-profile flow for SimpleResultData by explicitly failing fast when two models have no overlapping time periods, instead of proceeding into period-union logic that cannot produce a meaningful delta.
Changes:
- Add an explicit overlap check (
first_date >= last_date) inSimpleResultData.delta_profile. - Raise
EcalcErrorwith a compare-specific title/message when models do not overlap.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+390
to
+392
| if first_date >= last_date: | ||
| raise EcalcError(title="Compare error", message="The models periods does not overlap.") | ||
|
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tj098895
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
https://github.com/equinor/ecalc-internal/issues/1506