refactor: make generic from input compressor charts earlier #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
force-pushed
the
refactor/make-generic-from-input-compressor-charts-earlier
branch
from
299900e to
9066fe3
Compare
jsolaas
approved these changes
Apr 22, 2025
refactor: move generation of generic from input chart also for system
olelod
force-pushed
the
refactor/make-generic-from-input-compressor-charts-earlier
branch
from
9066fe3 to
c8807ce
Compare
olelod
changed the title
olelod
deleted the
refactor/make-generic-from-input-compressor-charts-earlier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the actual compressor model calculations to be performed by timestep, not all time steps at once. For the simplified compressor train, the compressor chart can be generated at run time (generic from input) based on the rate/pressure input. In this PR the generation of the generic from input compressor charts are done as soon as the rate/pressure expressions are evaluated.
Have you remembered and considered?
docs/drafts/next.draft.md)docs/docs/migration_guides/)BREAKING:in footer or!in header, if breakingECALC-XXXX)Why is this pull request needed?
This pull request is needed because of....
What does this pull request change?
Write summary of what this pull request changes if needed.
Issues related to this change: