Update default values in everest config schema #10431
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #10431 will not alter performanceComparing Summary
|
oyvindeide
force-pushed
the
update_schema
branch
from
6696e83 to
70d2379
Compare
DanSava
reviewed
Mar 21, 2025
| @@ -11,7 +11,6 @@ def test_input_constraint_initialization(): | |||
| cfg = relpath(cfg_dir, "config_input_constraints.yml") | |||
| config = EverestConfig.load_file(cfg) | |||
| # Check that an input constraint has been defined | |||
There was a problem hiding this comment.
I think this comment can be removed now
DanSava
previously approved these changes
Mar 21, 2025
oyvindeide
force-pushed
the
update_schema
branch
from
70d2379 to
c74dc60
Compare
oyvindeide
changed the title
oyvindeide
force-pushed
the
update_schema
branch
5 times, most recently
from
9fedf0b to
b252f80
Compare
oyvindeide
force-pushed
the
update_schema
branch
from
b252f80 to
48870b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove a lot of the "invalid" default values from the json schema and improve the documentation.
Old:
New:
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable