Skip to content

Add Ensemble Information Filter runmodel #10466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Mar 26, 2025

Add Ensemble Information filter runmodel to ERT
Issue
Resolves #10455, #10456, #10457, #10458, #10459

Screenshot 2025-03-25 at 12 43 40
Screenshot 2025-03-25 at 12 49 47

@yngve-sk yngve-sk force-pushed the enif-in-ert branch 8 times, most recently from ef5affc to 1d672f6 Compare March 26, 2025 14:18
@yngve-sk yngve-sk self-assigned this Mar 27, 2025
Copy link

codspeed-hq bot commented Mar 27, 2025

CodSpeed Performance Report

Merging #10466 will not alter performance

Comparing yngve-sk:enif-in-ert (fe20a27) with main (a76344f)

Summary

✅ 25 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_speed_performance_of_doing_enif_update[setup_es_benchmark0] N/A 123.9 ms N/A

@yngve-sk yngve-sk force-pushed the enif-in-ert branch 4 times, most recently from 3dd0800 to 219cd74 Compare April 4, 2025 11:52
@Blunde1
Copy link
Contributor

Blunde1 commented Apr 4, 2025

Har sett gjennom _es_update med litt kommentarar. Hovuddelen er bra.

Lasting av data: Vi må også filtrere ut responsar/observasjonar med NaN. Eg er ganske sikker på at dette blir gjort som preprosessering av data for dei andre oppdaterings algoritmene.


graph_u_sub = config_node.load_parameter_graph()

# This will work for dim(X_scaled) on order O(n^5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will likely add fit_precision_cholesky_approximate() to graphite-maps. This should scale better, also O(n^6 or n^7)

@yngve-sk yngve-sk force-pushed the enif-in-ert branch 2 times, most recently from 8b942bb to da40329 Compare April 11, 2025 08:42
@yngve-sk yngve-sk force-pushed the enif-in-ert branch 6 times, most recently from a59a7c5 to 635c577 Compare April 24, 2025 07:57
@yngve-sk yngve-sk force-pushed the enif-in-ert branch 11 times, most recently from e5d416b to 2134a14 Compare May 6, 2025 09:54
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember to squash the fixups

@yngve-sk yngve-sk force-pushed the enif-in-ert branch 12 times, most recently from c5ae8bc to ade1c3e Compare May 6, 2025 13:30
@yngve-sk yngve-sk merged commit 2079f4b into equinor:main May 7, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT May 7, 2025
@yngve-sk yngve-sk added the release-notes:new-feature Automatically categorise as new feature in release notes label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:new-feature Automatically categorise as new feature in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

EnIF available in ERT GUI
3 participants