Skip to content

Remove rebuild_dataclass in ErtConfig #10627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove rebuild_dataclass in ErtConfig #10627

wants to merge 1 commit into from

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Apr 14, 2025 •
edited
Loading

Issue
Resolves #9587

Approach
Remove rebuild_dataclass in ErtConfig

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@jonathan-eq jonathan-eq added the release-notes:skip If there should be no mention of this in release notes label Apr 14, 2025
@jonathan-eq jonathan-eq marked this pull request as ready for review April 14, 2025 11:32
@jonathan-eq
Copy link
Contributor Author

jonathan-eq commented Apr 14, 2025 •
edited
Loading

This passed locally on macos
EDIT: nvm, I was using pydantic 2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate need for rebuild_dataclass in ErtConfig
1 participant
@jonathan-eq