-
Notifications
You must be signed in to change notification settings - Fork 110
Remove event_from_dict function and ZMQ client from LegacyEnsemble #10634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonathan-eq
merged 2 commits into
equinor:main
from
jonathan-eq:remove_legacy_workaround
Apr 23, 2025
Merged
Remove event_from_dict function and ZMQ client from LegacyEnsemble #10634
jonathan-eq
merged 2 commits into
equinor:main
from
jonathan-eq:remove_legacy_workaround
Apr 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c440e5b
to
a17dd24
Compare
CodSpeed Performance ReportMerging #10634 will not alter performanceComparing Summary
|
xjules
reviewed
Apr 15, 2025
xjules
reviewed
Apr 15, 2025
a17dd24
to
0b33cce
Compare
xjules
reviewed
Apr 22, 2025
xjules
reviewed
Apr 22, 2025
xjules
reviewed
Apr 22, 2025
xjules
reviewed
Apr 22, 2025
0b33cce
to
2f604c2
Compare
xjules
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement @jonathan-eq ! 🚀
This commit changes LegacyEnsemble to put events directly in scheduler queue rather than sending it over ZMQ.
2f604c2
to
5de884e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach
This first commit in this PR removes the event_from_dict function and makes the callers create the Events directly instead. This increases the readability and makes it easier to find where the events are actually being created without having to jump through hoops and doing eight spins.
The second commit makes the LegacyEnsemble put events directly in the evaluator queue (which it has access to) instead of connecting to EE via ZMQ client and sending events. Before this commit, the client it used was also called dispatcher, which caused some confusion as to who was actually creating and sending Ensemble{Started,Cancelled,Stopped}.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests'
)When applicable