Skip to content

Add max_memory keyword to the Everest config #10637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Conversation

verveerpj
Copy link
Contributor

@verveerpj verveerpj commented Apr 15, 2025

Issue
Resolves #10624
Resolves #9569

Approach
Add the keyword, add to generated ert config

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@verveerpj verveerpj added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Apr 15, 2025
@verveerpj verveerpj self-assigned this Apr 15, 2025
@verveerpj verveerpj added this to SCOUT Apr 15, 2025
@verveerpj verveerpj moved this to In Progress in SCOUT Apr 15, 2025
@verveerpj verveerpj removed the status in SCOUT Apr 15, 2025
Copy link

codspeed-hq bot commented Apr 15, 2025

CodSpeed Performance Report

Merging #10637 will not alter performance

Comparing add-max_memory (c336dae) with main (9599946)

Summary

✅ 25 untouched benchmarks

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have one question that is slightly more work, but think it might be worth it in the long run, not sure what you think?

@verveerpj verveerpj force-pushed the add-max_memory branch 4 times, most recently from 3383365 to cd96e46 Compare April 16, 2025 15:05
@verveerpj verveerpj force-pushed the add-max_memory branch 2 times, most recently from d431fb3 to ec2014b Compare May 1, 2025 07:18
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this to Reviewed in SCOUT May 6, 2025
@verveerpj verveerpj merged commit 9c17dc2 into main May 6, 2025
27 checks passed
@verveerpj verveerpj deleted the add-max_memory branch May 6, 2025 10:10
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Not possible to set realization memory in Everest Unification of Int and Str input format in config file
3 participants