Skip to content

Log current working directory when starting Ert #10649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

berland
Copy link
Contributor

@berland berland commented Apr 15, 2025

Issue
Resolves human log parsing issue.

Approach

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@berland berland self-assigned this Apr 15, 2025
@berland berland added this to SCOUT Apr 15, 2025
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Apr 15, 2025
@berland berland moved this to Ready for Review in SCOUT Apr 15, 2025
Copy link

codspeed-hq bot commented Apr 15, 2025

CodSpeed Performance Report

Merging #10649 will not alter performance

Comparing berland:log_cwd (75a85f5) with main (15f6602)

Summary

✅ 25 untouched benchmarks

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@andreas-el andreas-el moved this from Ready for Review to Reviewed in SCOUT Apr 15, 2025
@berland berland enabled auto-merge (rebase) April 15, 2025 12:42
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 💯

@berland berland merged commit 0b26f5e into equinor:main Apr 22, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants