Skip to content

Conversation

@yngve-sk
Copy link
Contributor

added manual call to pass the global
logger to consumer plugins

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 12, 2025

CodSpeed Performance Report

Merging #11803 will not alter performance

Comparing yngve-sk:25.09.remove-pm-arg (d6b6313) with main (328ce8b)

Summary

✅ 22 untouched

@yngve-sk yngve-sk force-pushed the 25.09.remove-pm-arg branch 2 times, most recently from ae57d2b to 9a5685d Compare September 16, 2025 11:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.67%. Comparing base (328ce8b) to head (d6b6313).

Files with missing lines Patch % Lines
src/ert/__main__.py 80.00% 1 Missing ⚠️
src/ert/gui/main.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11803      +/-   ##
==========================================
- Coverage   90.70%   90.67%   -0.03%     
==========================================
  Files         431      431              
  Lines       29606    29602       -4     
==========================================
- Hits        26853    26841      -12     
- Misses       2753     2761       +8     
Flag Coverage Δ
cli-tests 37.69% <38.88%> (+<0.01%) ⬆️
gui-tests 68.77% <83.33%> (+<0.01%) ⬆️
performance-and-unit-tests 74.14% <88.88%> (+<0.01%) ⬆️
test 38.43% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the 25.09.remove-pm-arg branch 2 times, most recently from 0fa6731 to d21f8d4 Compare December 18, 2025 09:22
@yngve-sk yngve-sk marked this pull request as ready for review December 18, 2025 09:22
added manual call to pass the global
logger to consumer plugins
@yngve-sk yngve-sk force-pushed the 25.09.remove-pm-arg branch from d21f8d4 to d6b6313 Compare December 18, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants