Fix exporting parameters to runpath for design_matrix uses scientific notation #12480
+140
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
added
the
release-notes:bug-fix
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12480 +/- ##
===========================================
- Coverage 90.64% 76.19% -14.46%
===========================================
Files 430 431 +1
Lines 29481 29615 +134
===========================================
- Hits 26722 22564 -4158
- Misses 2759 7051 +4292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #12480 will not alter performanceComparing Summary
|
jonathan-eq
force-pushed
the
fix-dm
branch
2 times, most recently
from
56793cd to
8556b3f
Compare
jonathan-eq
changed the title
This commit fixes the issue where Ert converts large intergers to scientific notation when exporting design_matrix values to parameters.json, parameters.txt, and run templates.
xjules
reviewed
Dec 16, 2025
| else: | ||
| formatted_value = str(value) | ||
| param_substituter[f"<{param_name}>"] = formatted_value | ||
| param_substituter[f"<{param_name}>"] = str(value) |
Contributor
There was a problem hiding this comment.
Should it just stay with the if and f"{value:.6f}" ?
Contributor
Author
There was a problem hiding this comment.
Yes, thats the way it was before
9 tasks
Contributor
|
Superseded by #12535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #12427
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable