Add Latin Hypercube sampling #12525
Draft
Add Latin Hypercube sampling #12525
+206
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyod
reviewed
Jan 6, 2026
src/ert/config/parameter_config.py
Outdated
| def transform_data(self) -> Callable[[float], float]: | ||
| return lambda x: x | ||
|
|
||
| def sample_value( |
Contributor
There was a problem hiding this comment.
Since sample_value is called in a loop, I wonder if this should be re-written to samples VALUES (plural) instead. That way we avoid the O(n) computation inside each method call, so we get O(n) overall instead of O(n^2) and a bit more clarity in the code IMO.
Contributor
Author
There was a problem hiding this comment.
Do you mean this loop?
datasets = [ Ensemble.sample_parameter( config_node, realization_nr, random_seed=random_seed, num_realizations=num_realizations, ) for realization_nr in active_realizations ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft, do not merge.