Remove Webviz ERT and BaseService #12567
Open
+250
−726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
from
0b02fd9 to
0b0d56d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12567 +/- ##
==========================================
+ Coverage 90.55% 90.67% +0.11%
==========================================
Files 435 430 -5
Lines 29940 29702 -238
==========================================
- Hits 27112 26932 -180
+ Misses 2828 2770 -58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
2 times, most recently
from
1278c0c to
ed69bd1
Compare
yngve-sk
added
blocked
release-notes:breaking-change
yngve-sk
commented
Jan 6, 2026
|
|
||
|
|
||
| def run_webviz_ert(args: Namespace, _: ErtRuntimePlugins | None = None) -> None: | ||
| try: |
Contributor
Author
There was a problem hiding this comment.
note2self Add this back and give the notice that it is removed and that the misfits plot is available in ERT plotter
yngve-sk
commented
Jan 6, 2026
| @@ -1,42 +0,0 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| from collections.abc import Mapping | |||
Contributor
Author
There was a problem hiding this comment.
note2self also remove misfits endpoint (assuming only used by webviz ert)
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
from
ed69bd1 to
b872dad
Compare
Should not be hardcoded to 120
For clarity and easier testing, prefer singleton global string var over in-place hardcoding of strings.
To not lose test coverage when removing BaseService
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
from
b872dad to
375fc69
Compare
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
from
375fc69 to
372392b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: Should consider when to merge this in wrt deprecation warnings etc.