Have storage migrations done explicitly #12568
Conversation
andreas-el
force-pushed
the
explicit_migrations
branch
from
542606e to
f1250df
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12568 +/- ##
==========================================
- Coverage 90.55% 90.55% -0.01%
==========================================
Files 435 435
Lines 29940 29950 +10
==========================================
+ Hits 27112 27121 +9
- Misses 2828 2829 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andreas-el
force-pushed
the
explicit_migrations
branch
2 times, most recently
from
64f6475 to
83fe903
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Add test using explicit storage migration Add option to postpone storage reload until migration done Fixup storage migration tests Avoid migration overwriting version information for backups
andreas-el
force-pushed
the
explicit_migrations
branch
from
83fe903 to
b04fe58
Compare
andreas-el
added
the
release-notes:skip
andreas-el
changed the title
| @staticmethod | ||
| def perform_migration(path: Path) -> None: | ||
| if LocalStorage.check_migration_needed(path): | ||
| with LocalStorage(path, Mode("w"), True) as storage: |
There was a problem hiding this comment.
This is a lot better than what is currently here, but would it be hard to get more separation and make the migration happen without opening a write storage storage?
There was a problem hiding this comment.
Perhaps. Regardless I think that should be part of a different PR.
There was a problem hiding this comment.
👍 Can you set up a followup issue when merging this?
3 participants
Issue
Resolves #12518
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable