Detect missing arguments to DESIGN_MATRIX #12571

berland · 2026-01-05T14:35:43Z

If no arguments are given in the config file to DESIGN_MATRIX, a TypeError would be displayed:

TypeError: argument should be a str or an os.PathLike object where __fspath__ returns a str, not 'dict'
This commit adds detection and a test for this case.

Issue
Resolves #12570

Approach
🧠

PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

When there are user facing changes: Updated documentation
New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
Large PR: Prepare changes in small commits for more convenient review
Bug fix: Add regression test for the bug
Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

codecov-commenter · 2026-01-05T14:50:50Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.56%. Comparing base (2a0015b) to head (b6f070c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12571      +/-   ##
==========================================
- Coverage   90.58%   90.56%   -0.02%     
==========================================
  Files         435      435              
  Lines       29929    29931       +2     
==========================================
- Hits        27110    27108       -2     
- Misses       2819     2823       +4

Flag	Coverage Δ
cli-tests	`37.36% <100.00%> (+<0.01%)`	⬆️
gui-tests	`68.65% <100.00%> (-0.03%)`	⬇️
performance-and-unit-tests	`73.92% <100.00%> (-0.02%)`	⬇️
test	`38.11% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xjules

~~Nice one @berland ! 🚀~~

codspeed-hq · 2026-01-05T15:18:07Z

CodSpeed Performance Report

Merging #12571 will not alter performance

_{Comparing berland:detect_empty_design_matrix_args (b6f070c) with main (6681256)}

Summary

✅ 22 untouched

xjules

Actually, there is a bug in lark Schema config. Let's fix that instead:

ert/src/ert/config/parsing/config_schema.py

Line 268 in 78cae26

def design_matrix_keyword() -> SchemaItem:

berland · 2026-01-06T07:05:51Z

Actually, there is a bug in lark Schema config. Let's fix that instead:

You mean it is not respecting the argc_min=1? I guess it should yes.

berland · 2026-01-06T08:09:42Z

Actually, there is a bug in lark Schema config. Let's fix that instead:

You mean it is not respecting the argc_min=1? I guess it should yes.

Hopefully fixed now!

xjules · 2026-01-06T09:33:37Z

src/ert/config/parsing/config_schema_item.py

        self, line: Sequence[FileContextToken]
    ) -> Sequence[FileContextToken | dict[FileContextToken, FileContextToken]]:
        n = self.options_after
+        if not line:


berland · 2026-01-06T11:15:12Z

Related bug: #12578

xjules · 2026-01-06T11:19:42Z

tests/ert/unit_tests/config/parsing/test_schema_items.py

 from ert.config.parsing.config_schema_item import SchemaItem


+def test_argc_min():


test_schema_argc_min_invalid?

xjules · 2026-01-06T11:20:21Z

tests/ert/unit_tests/config/parsing/test_schema_items.py

+        parse_contents("OPTIONS", schema, "dummy_filename")
+
+
+def test_argc_min_with_options_after():


test_schema_argc_min_with_options_after?

xjules

Small suggestion for test names improvements, but otherwise 🏅

This solves a missing error message when e.g. DESIGN_MATRIX keyword is used with no arguments - a list with an empty dict was returned in the parser, leading to argc_min=1 to be accepted when it should not.

scout-team-app · 2026-01-06T11:54:52Z

Successfully created backport PR for version-18.0:

[Backport version-18.0] Detect missing arguments to DESIGN_MATRIX #12580

berland self-assigned this Jan 5, 2026

berland added the improvement Something nice to have, that will make life easier for developers or users or both. label Jan 5, 2026

berland added this to SCOUT Jan 5, 2026

berland moved this to Ready for Review in SCOUT Jan 5, 2026

berland added bug backport version-18.0 release-notes:bug-fix Automatically categorise as bug fix in release notes labels Jan 5, 2026

berland force-pushed the detect_empty_design_matrix_args branch from 5ee71fb to 118aad8 Compare January 5, 2026 14:38

berland moved this from Ready for Review to Fast Track in SCOUT Jan 5, 2026

berland removed this from SCOUT Jan 5, 2026

xjules approved these changes Jan 5, 2026

View reviewed changes

xjules requested changes Jan 5, 2026

View reviewed changes

berland force-pushed the detect_empty_design_matrix_args branch from 89938f9 to b8389b2 Compare January 6, 2026 08:06

xjules reviewed Jan 6, 2026

View reviewed changes

xjules approved these changes Jan 6, 2026

View reviewed changes

berland force-pushed the detect_empty_design_matrix_args branch 2 times, most recently from f8c5290 to 3283353 Compare January 6, 2026 11:29

berland enabled auto-merge (rebase) January 6, 2026 11:29

berland disabled auto-merge January 6, 2026 11:37

berland added 2 commits January 6, 2026 12:40

Add test for argc_min in schema parsing

7a028c0

Fix argument count when options_after is used

b6f070c

This solves a missing error message when e.g. DESIGN_MATRIX keyword is used with no arguments - a list with an empty dict was returned in the parser, leading to argc_min=1 to be accepted when it should not.

berland force-pushed the detect_empty_design_matrix_args branch from 3283353 to b6f070c Compare January 6, 2026 11:40

berland enabled auto-merge (rebase) January 6, 2026 11:41

berland merged commit 2041366 into equinor:main Jan 6, 2026
34 checks passed

scout-team-app bot mentioned this pull request Jan 6, 2026

[Backport version-18.0] Detect missing arguments to DESIGN_MATRIX #12580

Merged

		from ert.config.parsing.config_schema_item import SchemaItem


		def test_argc_min():

		parse_contents("OPTIONS", schema, "dummy_filename")


		def test_argc_min_with_options_after():

Detect missing arguments to DESIGN_MATRIX #12571

Detect missing arguments to DESIGN_MATRIX #12571

Conversation

berland commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

When applicable

Uh oh!

codecov-commenter commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

xjules left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #12571 will not alter performance

Summary

Uh oh!

xjules left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

berland commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

berland commented Jan 6, 2026

Uh oh!

xjules Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

berland commented Jan 6, 2026

Uh oh!

xjules Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

xjules Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

xjules left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

scout-team-app bot commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

berland commented Jan 5, 2026 •

edited

Loading

codecov-commenter commented Jan 5, 2026 •

edited

Loading

xjules left a comment •

edited

Loading

codspeed-hq bot commented Jan 5, 2026 •

edited

Loading

xjules left a comment •

edited

Loading

berland commented Jan 6, 2026 •

edited

Loading