Added collapsible sidepanels for PlotWindow - #13896
Merged
Merged
Conversation
eilskra
added
the
improvement
eilskra
force-pushed
the
create-plot-widget-files
branch
2 times, most recently
from
June 26, 2026 09:55
44769ce to
bc16cea
Compare
eilskra
changed the title
PlotWindow
eilskra
force-pushed
the
create-plot-widget-files
branch
from
June 26, 2026 10:09
bc16cea to
40d7872
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13896 +/- ##
==========================================
+ Coverage 91.34% 91.36% +0.01%
==========================================
Files 477 481 +4
Lines 34062 34112 +50
==========================================
+ Hits 31115 31166 +51
+ Misses 2947 2946 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the PlotWindow GUI layout to replace dock-based side panels with splitter-based side panels, and extracts plot-control UI elements into dedicated widgets/utilities to reduce duplication and avoid the QDockWidget-related duplication/undocking issues.
Changes:
- Replaced
QDockWidgetside panels inPlotWindowwith aQSplitter+ reusable side-panel helpers. - Extracted Everest controls plot options and misfits plot options into dedicated widget classes under
widgets/plot_controls/. - Added Qt UI utility helpers (
qt_creator.py) and new unit tests for the extracted widgets/utilities.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/ert/gui/plotting/plot_window.py |
Switches layout to QSplitter side panels and wires in extracted plot-control widgets. |
src/ert/gui/plotting/utils/qt_creator.py |
Adds shared UI helpers for side panels and group-box/layout creation. |
src/ert/gui/plotting/widgets/plot_controls/misfits_options.py |
New misfits options widget wrapper exposing checkbox state. |
src/ert/gui/plotting/widgets/plot_controls/everest_controls_plot_options.py |
New Everest controls plot options widget wrapper for x-axis selection. |
src/ert/gui/plotting/widgets/plot_controls/__init__.py |
Exposes the new plot-control widgets as a small public module surface. |
tests/ert/unit_tests/gui/plotting/widgets/test_misfits_options.py |
Adds unit tests for MisfitsOptions defaults, state updates, and callback triggering. |
tests/ert/unit_tests/gui/plotting/widgets/test_everest_controls_plot_options.py |
Adds unit tests for EverestControlsPlotOptions defaults and callback triggering. |
tests/ert/unit_tests/gui/plotting/utils/test_qt_creator.py |
Adds unit tests for the new Qt creator helpers. |
Comment on lines
+14
to
+25
| self._toggle_mean = QCheckBox("Show mean") | ||
| self._toggle_mean.setChecked(True) | ||
| self._toggle_mean.stateChanged.connect(connection_point) | ||
| self._toggle_outliers = QCheckBox("Show outliers") | ||
| self._toggle_outliers.setChecked(True) | ||
| self._toggle_outliers.stateChanged.connect(connection_point) | ||
| self._toggle_scatter_plot = QCheckBox("Show scatter") | ||
| self._toggle_scatter_plot.setChecked(False) | ||
| self._toggle_scatter_plot.stateChanged.connect(connection_point) | ||
| self._toggle_box = QCheckBox("Show box plot") | ||
| self._toggle_box.setChecked(True) | ||
| self._toggle_box.stateChanged.connect(connection_point) |
Comment on lines
+20
to
+23
| self._display_over_button_group = QButtonGroup() | ||
| self._display_over_button_group.addButton(self._display_over_batches_radio) | ||
| self._display_over_button_group.addButton(self._display_over_controls_radio) | ||
| self._display_over_button_group.buttonClicked.connect(connection_point) |
eilskra
force-pushed
the
create-plot-widget-files
branch
3 times, most recently
from
June 26, 2026 15:08
d34f3a7 to
7a457ed
Compare
berland
approved these changes
Jun 29, 2026
berland
left a comment
berland
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Can the copilot comments be ignored?
Contributor
Author
Ignored similar comment in regarding the layer in previous PR |
Contributor
Author
|
Blocked until #13843 is merged |
This comment was marked as outdated.
This comment was marked as outdated.
eilskra
force-pushed
the
create-plot-widget-files
branch
2 times, most recently
from
July 8, 2026 08:08
569def0 to
7a457ed
Compare
Also started the move of the util create_box and create_layout
Not using the functionality of QDockWidget Now uses splitter instead, allows user to collapse sidepanels Note: tests for this feature was added to last commit
Similar to MisfitsOptions, also improved imports
eilskra
force-pushed
the
create-plot-widget-files
branch
from
July 8, 2026 08:43
7a457ed to
7e5b85a
Compare
Collaborator
|
Screenshots differ from baselines. A baseline update PR has been prepared: equinor/ert-testdata#43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #11083
Part of #13883
Resolves #11066
Resolves #
Approach
Moved sidepanels from
QDockWidgettoQSplitterto avoid duplication error, makingQDocketWidgetnot necessary.Now have collapsible sidepanels
Moved plot options in their own respective widgets
https://github.com/user-attachments/assets/84375799-fbd1-4ea4-b983-22dc04e96893
git rebase -i main --exec 'just rapid-tests')When applicable