Skip to content

Replace failing test_invalid_subconfig subtest - #14055

Merged
achaikou merged 1 commit into
equinor:mainfrom
achaikou:everest_robust_test
Jul 30, 2026
Merged

Replace failing test_invalid_subconfig subtest#14055
achaikou merged 1 commit into
equinor:mainfrom
achaikou:everest_robust_test

Conversation

@achaikou

Copy link
Copy Markdown
Contributor

test_invalid_subconfig began failing due to changes in the environment.

Test happened to verify that a validation error is thrown when all directories on the path are unwritable.

  1. this is difficult to reproduce in controlled test setup.
  2. intuitively one would expect that it is enough for provided directory to be writable, yet check is implemented to verify all directories along the path. Reason for this is unclear.
  3. it is unclear if test on purpose used a path with all directories unwritable or if it was an accident.

As expected behavior is unknown, create a x-failing replacement test for behavior to be verified in the future.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When screenshots are changed: Review screenshot-PR in ert-testdata,
    merge screenshot-PR in ert-testdata before merging this PR.
  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

test_invalid_subconfig began failing due to changes in the environment.

Test happened to verify that a validation error is thrown when all
directories on the path are unwritable.
1. this is difficult to reproduce in controlled test setup.
2. intuitively one would expect that it is enough for provided directory
to be writable, yet check is implemented to verify all directories along
the path. Reason for this is unclear.
3. it is unclear if test on purpose used a path with all directories
unwritable  or if it was an accident.

As expected behavior is unknown, create a x-failing replacement test for
behavior to be verified in the future.
@achaikou achaikou added the release-notes:skip If there should be no mention of this in release notes label Jul 30, 2026
@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.83%. Comparing base (ae2f9f1) to head (6c5463b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14055      +/-   ##
==========================================
- Coverage   91.85%   91.83%   -0.02%     
==========================================
  Files         481      480       -1     
  Lines       33342    33337       -5     
==========================================
- Hits        30626    30615      -11     
- Misses       2716     2722       +6     
Flag Coverage Δ
cli-tests 36.34% <ø> (+<0.01%) ⬆️
fuzz 44.11% <ø> (-0.02%) ⬇️
gui-tests 58.38% <ø> (-0.06%) ⬇️
performance-and-unit-tests 80.38% <ø> (-0.02%) ⬇️
test 46.46% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

@achaikou
achaikou marked this pull request as ready for review July 30, 2026 11:57
@achaikou achaikou added this to SCOUT Jul 30, 2026
@achaikou achaikou moved this to Ready for Review in SCOUT Jul 30, 2026
@ajaust ajaust self-assigned this Jul 30, 2026
@github-project-automation github-project-automation Bot moved this from Ready for Review to Reviewed in SCOUT Jul 30, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing achaikou:everest_robust_test (6c5463b) with main (91d37b4)

Open in CodSpeed

@achaikou
achaikou merged commit d9fe003 into equinor:main Jul 30, 2026
36 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in SCOUT Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:skip If there should be no mention of this in release notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants