Handle runtime plugins in bulk converter - #14073
Merged
Merged
Conversation
SAKavli
added
the
release-notes:unreleased-bug-fix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14073 +/- ##
==========================================
- Coverage 91.83% 91.82% -0.01%
==========================================
Files 482 482
Lines 33444 33453 +9
==========================================
+ Hits 30713 30718 +5
- Misses 2731 2735 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes summary_to_bulk conversion failing when the ERT config includes hooked workflows that reference workflow jobs provided by runtime plugins. It does so by ensuring ErtConfig is loaded with the runtime plugin context during conversion.
Changes:
- Thread runtime plugin information through the observation converter dispatcher and into
convert_summary_to_bulk. - Load
ErtConfigviaErtConfig.with_plugins(runtime_plugins)so plugin-provided workflow jobs are available during config parsing/validation. - Update and extend unit tests to pass plugin context and add a regression test for hooked workflows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/ert/observation_converters/summary_to_bulk.py |
Loads ErtConfig with runtime plugins to prevent failures when plugin jobs are referenced. |
src/ert/observation_converters/dispatcher.py |
Passes runtime plugin data into converter functions. |
tests/ert/unit_tests/cli/test_summary_to_bulk.py |
Updates existing tests for new converter signature and adds a regression test covering hooked workflows + plugin jobs. |
SAKavli
force-pushed
the
investigate-hooked-workflow-bug
branch
2 times, most recently
from
August 3, 2026 11:54
6faf460 to
a6135f9
Compare
The summary_to_bulk would fail if any runtime plugins are configured in the ert configuration. This was revealed when testing the tooling on Drogon. This change will load the ErtConfig with respect to runtime plugins such that the workflow does not fail.
ErtConfig will oftentimes raise warnings regarding the experiment setup which is not relevant for this tooling. We will only be interested in errors raised during the setup of the ErtConfig and the tooling itself.
SAKavli
force-pushed
the
investigate-hooked-workflow-bug
branch
from
August 3, 2026 12:18
a6135f9 to
9a18753
Compare
ajaust
approved these changes
Aug 3, 2026
ajaust
left a comment
ajaust
left a comment
Contributor
There was a problem hiding this comment.
Looks nice! I have two small comments. You may decide what to do with them. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The summary_to_bulk would fail if any runtime plugins are configured in the ert configuration. This was revealed when testing the tooling on Drogon.
This change will load the ErtConfig with respect to runtime plugins such that the workflow does not fail.
Appended some extra fixup commits to consistently handle warnings and errors among the bulk and yaml (other PR) converter.