Add parquet support for seismic - #14135
Merged
Merged
Conversation
akustn
force-pushed
the
add-parquet-support
branch
from
August 12, 2026 11:38
7ced64d to
ed74bbe
Compare
akustn
marked this pull request as ready for review
August 12, 2026 11:38
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14135 +/- ##
==========================================
- Coverage 91.92% 91.91% -0.01%
==========================================
Files 482 482
Lines 33498 33513 +15
==========================================
+ Hits 30794 30805 +11
- Misses 2704 2708 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ajaust
self-requested a review
August 13, 2026 06:42
ajaust
reviewed
Aug 13, 2026
ajaust
left a comment
Contributor
There was a problem hiding this comment.
Nice changes!
Minor commit-message suggestions:
- The commit messages switch between
parquetand.parquet. Pick one and be consistent. Maybe useparquetwhen referring to the file format, and reserve.parquetfor the literal file extension. - Commit subjects can focus more on thevisible change than the implementation location (the actual file); Git already records the affected files. For example, "Support parquet seismic response files in SeismicConfig" is closer to the style used in the project than "Add support for parquet to seismic_config.py". If useful context is needed, add the rationale in the commit body.
akustn
force-pushed
the
add-parquet-support
branch
4 times, most recently
from
August 14, 2026 12:29
a33a8aa to
a70d4b4
Compare
ajaust
approved these changes
Aug 14, 2026
ajaust
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Squash the fixups and then feel free to merge. 🎉
akustn
force-pushed
the
add-parquet-support
branch
from
August 14, 2026 13:01
a70d4b4 to
e523e94
Compare
The values in the csv files change, because they have been calculated with a hash based on the file name. The hash calculation is now changed to be calculated based on the file stem, excluding .csv or .parquet, to ensure that both the csv and the parquet example operate with the same values.
akustn
force-pushed
the
add-parquet-support
branch
from
August 17, 2026 06:40
e523e94 to
7b3ae66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #13910
Approach
I approached the issue from the seismic_example, and adjusted the mock to support the usage of .parquet files.
I further adjusted the seismic config and the SeismicObservation to offer .parquet file support.
In addition I added an example to seismic_example that runs with .parquet files and adjusted the README.md accordingly.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.