Skip to content

Add parquet support for seismic - #14135

Merged
akustn merged 6 commits into
mainfrom
add-parquet-support
Aug 17, 2026
Merged

Add parquet support for seismic#14135
akustn merged 6 commits into
mainfrom
add-parquet-support

Conversation

@akustn

@akustn akustn commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Issue
Resolves #13910

Approach
I approached the issue from the seismic_example, and adjusted the mock to support the usage of .parquet files.
I further adjusted the seismic config and the SeismicObservation to offer .parquet file support.
In addition I added an example to seismic_example that runs with .parquet files and adjusted the README.md accordingly.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When screenshots are changed: Review screenshot-PR in ert-testdata,
    merge screenshot-PR in ert-testdata before merging this PR.
  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@akustn akustn self-assigned this Aug 11, 2026
@akustn akustn added the release-notes:improvement Automatically categorise as improvement in release notes label Aug 11, 2026
@akustn akustn added this to SCOUT Aug 11, 2026
@akustn
akustn force-pushed the add-parquet-support branch from 7ced64d to ed74bbe Compare August 12, 2026 11:38
@akustn
akustn marked this pull request as ready for review August 12, 2026 11:38
@akustn akustn changed the title Add parquet support Add parquet support for seismic Aug 12, 2026
@codecov-commenter

codecov-commenter commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.91%. Comparing base (57d74db) to head (7b3ae66).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14135      +/-   ##
==========================================
- Coverage   91.92%   91.91%   -0.01%     
==========================================
  Files         482      482              
  Lines       33498    33513      +15     
==========================================
+ Hits        30794    30805      +11     
- Misses       2704     2708       +4     
Flag Coverage Δ
cli-tests 36.46% <0.00%> (-0.02%) ⬇️
fuzz 44.45% <0.00%> (-0.02%) ⬇️
gui-tests 58.81% <0.00%> (-0.03%) ⬇️
performance-and-unit-tests 80.80% <100.00%> (-0.01%) ⬇️
test 45.97% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ert/config/_observations.py 95.61% <100.00%> (+0.07%) ⬆️
src/ert/config/seismic_config.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@codspeed-hq

codspeed-hq Bot commented Aug 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing add-parquet-support (7b3ae66) with main (92ced06)

Open in CodSpeed

@ajaust
ajaust self-requested a review August 13, 2026 06:42

@ajaust ajaust left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes!

Minor commit-message suggestions:

  • The commit messages switch between parquet and .parquet. Pick one and be consistent. Maybe use parquet when referring to the file format, and reserve  .parquet for the literal file extension.
  • Commit subjects can focus more on thevisible change than the implementation location (the actual file); Git already records the affected files. For example, "Support parquet seismic response files in SeismicConfig" is closer to the style used in the project than "Add support for parquet to seismic_config.py". If useful context is needed, add the rationale in the commit body.

Comment thread test-data/ert/seismic_example/mock_sim2seis.py Outdated
Comment thread test-data/ert/seismic_example/mock_sim2seis.py Outdated
Comment thread test-data/ert/seismic_example/mock_sim2seis.py Outdated
Comment thread src/ert/config/_observations.py
Comment thread tests/ert/unit_tests/config/test_observation_declaration.py
Comment thread src/ert/config/_observations.py
Comment thread src/ert/config/_observations.py Outdated
Comment thread src/ert/config/_observations.py Outdated
Comment thread src/ert/config/_observations.py Outdated
@akustn
akustn force-pushed the add-parquet-support branch 4 times, most recently from a33a8aa to a70d4b4 Compare August 14, 2026 12:29

@ajaust ajaust left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Squash the fixups and then feel free to merge. 🎉

@github-project-automation github-project-automation Bot moved this to Reviewed in SCOUT Aug 14, 2026
@akustn
akustn force-pushed the add-parquet-support branch from a70d4b4 to e523e94 Compare August 14, 2026 13:01
akustn added 6 commits August 17, 2026 08:29
The values in the csv files change, because they have been calculated
with a hash based on the file name. The hash calculation is now changed
to be calculated based on the file stem, excluding .csv or .parquet, to
ensure that both the csv and the parquet example operate with the same
values.
@akustn
akustn force-pushed the add-parquet-support branch from e523e94 to 7b3ae66 Compare August 17, 2026 06:40
@akustn
akustn merged commit 39b7142 into main Aug 17, 2026
38 checks passed
@akustn
akustn deleted the add-parquet-support branch August 17, 2026 07:38
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in SCOUT Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:improvement Automatically categorise as improvement in release notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Support .parquet files for seismic

3 participants