Skip to content

Rename Restart run mda gui label to Select prior - #14190

Closed
tbwiik wants to merge 1 commit into
equinor:mainfrom
tbwiik:gui-mda-rename-restart-run-button
Closed

Rename Restart run mda gui label to Select prior#14190
tbwiik wants to merge 1 commit into
equinor:mainfrom
tbwiik:gui-mda-rename-restart-run-button

Conversation

@tbwiik

@tbwiik tbwiik commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Issue
Resolves #11920

Approach
See #14175.
Forgot to make migration and tests which is reason for reopen and new PR.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When screenshots are changed: Review screenshot-PR in ert-testdata,
    merge screenshot-PR in ert-testdata before merging this PR.
  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@tbwiik
tbwiik requested a review from SAKavli August 14, 2026 14:35
@tbwiik tbwiik self-assigned this Aug 14, 2026
@tbwiik tbwiik changed the title Gui mda rename restart run button Rename Restart run mda gui label to Select prior Aug 14, 2026
@tbwiik tbwiik added the release-notes:improvement Automatically categorise as improvement in release notes label Aug 14, 2026
@codecov-commenter

codecov-commenter commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.91%. Comparing base (87d7a72) to head (f808ad4).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/storage/migration/to38.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14190      +/-   ##
==========================================
- Coverage   91.92%   91.91%   -0.02%     
==========================================
  Files         482      483       +1     
  Lines       33498    33523      +25     
==========================================
+ Hits        30794    30813      +19     
- Misses       2704     2710       +6     
Flag Coverage Δ
cli-tests 36.45% <3.84%> (-0.04%) ⬇️
fuzz 44.46% <34.61%> (-0.02%) ⬇️
gui-tests 58.79% <3.84%> (-0.05%) ⬇️
performance-and-unit-tests 80.80% <92.30%> (-0.01%) ⬇️
test 45.96% <3.84%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ert/storage/local_storage.py 92.90% <100.00%> (ø)
src/ert/storage/migration/to38.py 92.00% <92.00%> (ø)

... and 3 files with indirect coverage changes

@codspeed-hq

codspeed-hq Bot commented Aug 14, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing tbwiik:gui-mda-rename-restart-run-button (6917dd9) with main (8b3c3f4)

Open in CodSpeed

@tbwiik

tbwiik commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

messed up the branch; learning in progress. See #14194

@tbwiik tbwiik closed this Aug 17, 2026
@tbwiik
tbwiik deleted the gui-mda-rename-restart-run-button branch August 17, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:improvement Automatically categorise as improvement in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gui ESMDA unclear button 'restart run'

2 participants