Skip to content

Allow both E and F states for a killed OpenPBS job - #14191

Merged
berland merged 1 commit into
equinor:mainfrom
berland:fix_openpbs_test
Aug 17, 2026
Merged

Allow both E and F states for a killed OpenPBS job#14191
berland merged 1 commit into
equinor:mainfrom
berland:fix_openpbs_test

Conversation

@berland

@berland berland commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

E is a transitional state, and it will later progress to F when the queue system is done with it. In this test we pick up either E or F depending on star alignment.

Issue
Resolves #14142

Approach
🧠

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When screenshots are changed: Review screenshot-PR in ert-testdata,
    merge screenshot-PR in ert-testdata before merging this PR.
  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@berland berland self-assigned this Aug 17, 2026
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Aug 17, 2026
@berland
berland requested a lite review from Copilot August 17, 2026 05:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the OpenPBS scheduler unit test to tolerate the transitional E (exiting) state in addition to F (failed) when a job is killed, addressing observed CI flakiness where E may be reported before transitioning to F.

Changes:

  • Relaxed the OpenPBS job-state assertion to accept either E or F for a killed job.
  • Updated the assertion message to reflect the broader accepted states.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/ert/unit_tests/scheduler/test_openpbs_driver.py Outdated
E is a transitional state, and it will later progress to F when
the queue system is done with it. In this test we pick up either E
or F depending on star alignment.
@codecov-commenter

codecov-commenter commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.91%. Comparing base (8b3c3f4) to head (b136b6a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14191      +/-   ##
==========================================
- Coverage   91.92%   91.91%   -0.02%     
==========================================
  Files         482      482              
  Lines       33498    33498              
==========================================
- Hits        30794    30790       -4     
- Misses       2704     2708       +4     
Flag Coverage Δ
cli-tests 36.47% <ø> (ø)
fuzz 44.47% <ø> (ø)
gui-tests 58.84% <ø> (-0.01%) ⬇️
performance-and-unit-tests 80.79% <ø> (-0.02%) ⬇️
test 45.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

@andreas-el andreas-el left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐ (they are aligned)

@berland
berland merged commit 92ced06 into equinor:main Aug 17, 2026
34 checks passed
@eqbech

eqbech commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Should these comments be updated by this new information?
image

@berland

berland commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Should these comments be updated by this new information? image

This is what I read in order to fix this, so it is not wrong. Maybe you would like "exiting" to be more precise?

@codspeed-hq

codspeed-hq Bot commented Aug 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing berland:fix_openpbs_test (b136b6a) with main (8b3c3f4)

Open in CodSpeed

@scout-team-app

Copy link
Copy Markdown

Successfully created backport PR for version-24.0:

@eqbech

eqbech commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

It is probably fine as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport version-24.0 release-notes:skip If there should be no mention of this in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solve test failure test_that_queue_system_can_kill_before_scheduler_with_negative_padding

5 participants