Allow both E and F states for a killed OpenPBS job - #14191
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the OpenPBS scheduler unit test to tolerate the transitional E (exiting) state in addition to F (failed) when a job is killed, addressing observed CI flakiness where E may be reported before transitioning to F.
Changes:
- Relaxed the OpenPBS job-state assertion to accept either
EorFfor a killed job. - Updated the assertion message to reflect the broader accepted states.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
E is a transitional state, and it will later progress to F when the queue system is done with it. In this test we pick up either E or F depending on star alignment.
2504f8f to
b136b6a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14191 +/- ##
==========================================
- Coverage 91.92% 91.91% -0.02%
==========================================
Files 482 482
Lines 33498 33498
==========================================
- Hits 30794 30790 -4
- Misses 2704 2708 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
andreas-el
left a comment
There was a problem hiding this comment.
⭐ ⭐ ⭐ (they are aligned)
|
Successfully created backport PR for |
|
It is probably fine as is. |


E is a transitional state, and it will later progress to F when the queue system is done with it. In this test we pick up either E or F depending on star alignment.
Issue
Resolves #14142
Approach
🧠
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.