Fix Qt race condition when repainting - #14193
Draft
ajaust wants to merge 2 commits into
Draft
Conversation
It seems that we occasionally resize the plot side panel while Qt is repainting widgets. This reenters the repaint manager causing a segmentation fauult. Defer all layout changes with QTimer.singleShot(0).
It seems that we occasionally change the visibility of a widget while Qt is repainting widgets. This reenters the repaint manager causing a segmentation fault. Defer the visibility change with QTimer.singleShot(0).
Collaborator
|
Screenshots differ from baselines. A baseline update PR has been prepared: equinor/ert-testdata#85 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14193 +/- ##
==========================================
- Coverage 91.92% 91.91% -0.01%
==========================================
Files 482 482
Lines 33479 33500 +21
==========================================
+ Hits 30775 30792 +17
- Misses 2704 2708 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #14192
Approach
Delaying repainting of widgets by moving them to end of the event queue.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.