Skip to content

Disable param updating experiments when design matrix #14209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tbwiik wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −8
Draft

Disable param updating experiments when design matrix #14209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/ert/gui/experiments/experiment_panel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,12 @@ def __init__(
True,
)

experiment_type_valid = any(
p.update_strategy is not None
for p in config.ensemble_config.parameter_configs.values()
) and bool(config.observation_declarations)
merged_parameters = config.parameter_configurations_with_design_matrix
updatable_parameters_exist = any(
p.update_strategy is not None for p in merged_parameters
)
Comment on lines +206 to +209

@tbwiik tbwiik Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be valuable to combine these two vars here?

observations_exist = bool(config.observation_declarations)
experiment_model_enabled = updatable_parameters_exist and observations_exist

self.addExperimentConfigPanel(
MultipleDataAssimilationPanel(
Expand All @@ -217,7 +219,7 @@ def __init__(
active_realizations,
config_num_realization,
),
experiment_type_valid,
experiment_model_enabled,
)
self.addExperimentConfigPanel(
EnsembleSmootherPanel(
Expand All @@ -228,7 +230,7 @@ def __init__(
active_realizations,
config_num_realization,
),
experiment_type_valid,
experiment_model_enabled,
)
self.addExperimentConfigPanel(
EnsembleInformationFilterPanel(
Expand All @@ -239,11 +241,11 @@ def __init__(
active_realizations,
config_num_realization,
),
experiment_type_valid,
experiment_model_enabled,
)
self.addExperimentConfigPanel(
ManualUpdatePanel(run_path, notifier, analysis_config),
experiment_type_valid,
experiment_model_enabled,
)

self.configuration_summary = SummaryPanel(config)
Expand Down
Loading