Skip to content

[Backport version-24.0] Assure breakthrough time is always cast to ms - #14214

Merged
achaikou merged 1 commit into
version-24.0from
backport-14207-to-version-24.0
Aug 19, 2026
Merged

[Backport version-24.0] Assure breakthrough time is always cast to ms#14214
achaikou merged 1 commit into
version-24.0from
backport-14207-to-version-24.0

Conversation

@scout-team-app

Copy link
Copy Markdown

Description

Backport of #14207 to version-24.0.

Reproduces and fixes #13962

(cherry picked from commit 293883c)
@scout-team-app scout-team-app Bot added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.32%. Comparing base (70f2d66) to head (eab2512).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##           version-24.0   #14214      +/-   ##
================================================
+ Coverage         91.30%   91.32%   +0.01%     
================================================
  Files               478      478              
  Lines             34077    34081       +4     
================================================
+ Hits              31115    31124       +9     
+ Misses             2962     2957       -5     
Flag Coverage Δ
cli-tests 35.93% <40.00%> (-0.02%) ⬇️
fuzz 43.51% <40.00%> (+<0.01%) ⬆️
gui-tests 59.18% <40.00%> (-0.01%) ⬇️
performance-and-unit-tests 79.39% <100.00%> (+0.01%) ⬆️
test 45.96% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ert/config/breakthrough_config.py 97.87% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

@codspeed-hq

codspeed-hq Bot commented Aug 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing backport-14207-to-version-24.0 (eab2512) with version-24.0 (70f2d66)

Open in CodSpeed

@achaikou
achaikou merged commit 7f8c744 into version-24.0 Aug 19, 2026
39 checks passed
@achaikou
achaikou deleted the backport-14207-to-version-24.0 branch August 19, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:bug-fix Automatically categorise as bug fix in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants