fix: remove date from config in well traj test#122
Closed
StephanDeHoop wants to merge 1 commit intomainfrom
Closed
fix: remove date from config in well traj test#122StephanDeHoop wants to merge 1 commit intomainfrom
date from config in well traj test#122StephanDeHoop wants to merge 1 commit intomainfrom
Conversation
StephanDeHoop
force-pushed
the
remove-line-from-config-in-test
branch
from
6c65522 to
df92cff
Compare
Contributor
|
Closing due to merging #119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to either merge this PR or the other PR (#119) after the recent changes in everest-models to the well-trajectory forward model (specifying
datefor dynamic perforations only), otherwise the tests will fail this weekend for well trajectory tutorial when tested on bleeding. I am off until Monday, feel free to merge either one to prevent the test from failing.Either fix is fine, this ensures that the well-trajectory is not ahead of latest (stable) everest release.