Skip to content

Remove Area#2015

Merged
Christdej merged 1 commit intoequinor:mainfrom
Christdej:removearea
Mar 12, 2025
Merged

Remove Area#2015
Christdej merged 1 commit intoequinor:mainfrom
Christdej:removearea

Conversation

@Christdej
Copy link
Copy Markdown
Contributor

@Christdej Christdej commented Feb 10, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Christdej Christdej added backend Backend related functionality breaking-change A breaking change which introduces changes to the public APIs frontend Frontend related functionality labels Feb 10, 2025
@Christdej Christdej self-assigned this Feb 10, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2025

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Christdej
Copy link
Copy Markdown
Contributor Author

Christdej commented Feb 10, 2025

Will now give warnings on Return to Home missions if they fail becuase we dont have an Area, awaiting Return Home functionallity to be removed aswell.

@Christdej Christdej force-pushed the removearea branch 3 times, most recently from 1e99cac to 8029def Compare February 10, 2025 13:54
andchiind
andchiind reviewed Feb 11, 2025
View reviewed changes
@Christdej Christdej force-pushed the removearea branch 2 times, most recently from 4d9b2be to 1c92591 Compare February 13, 2025 09:00
@andchiind
Copy link
Copy Markdown
Contributor

andchiind commented Feb 13, 2025

We could potentially link this issue: #1840, but that will depend on how we solve the inspection area issue

@Christdej
Copy link
Copy Markdown
Contributor Author

Christdej commented Feb 13, 2025

Rest of work to be done documented in:
#2024

@Christdej Christdej requested a review from andchiind February 14, 2025 09:08
@tsundvoll
Copy link
Copy Markdown
Contributor

tsundvoll commented Feb 17, 2025 •
edited
Loading

Done once per asset (possible with multiple inspection areas per asset) (not per mission)

awaiting

  • using a polygon to define area
  • moving ReturnToHome to ISAR

@Christdej Christdej force-pushed the removearea branch 9 times, most recently from 13d543e to c18b9f6 Compare March 10, 2025 06:15
@Christdej Christdej force-pushed the removearea branch 2 times, most recently from e179658 to c14365d Compare March 12, 2025 08:25
mrica-equinor
mrica-equinor reviewed Mar 12, 2025
View reviewed changes
@Christdej Christdej force-pushed the removearea branch 2 times, most recently from 7b6cf15 to f62c2e3 Compare March 12, 2025 13:07
mrica-equinor
mrica-equinor reviewed Mar 12, 2025
View reviewed changes
mrica-equinor
mrica-equinor approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2025

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Mar 12, 2025
@Christdej
Copy link
Copy Markdown
Contributor Author

Christdej commented Mar 12, 2025

/UpdateDatabase

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2025

👀 Running migration command... 👀

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2025

✨ Successfully ran migration command! ✨

@Christdej Christdej merged commit 40997cf into equinor:main Mar 12, 2025
14 checks passed
@Christdej Christdej deleted the removearea branch March 12, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrica-equinor mrica-equinor mrica-equinor approved these changes

@andchiind andchiind Awaiting requested review from andchiind

Assignees

@Christdej Christdej

Labels

backend Backend related functionality breaking-change A breaking change which introduces changes to the public APIs database-change Will require migration frontend Frontend related functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Christdej @andchiind @tsundvoll @mrica-equinor