Redirect to asset page if no installation selected#2049
Redirect to asset page if no installation selected#2049mrica-equinor merged 2 commits intoequinor:mainfrom
Conversation
mrica-equinor
changed the title
|
Closes #2042 |
mrica-equinor
force-pushed
the
redirect-to-asset-page
branch
3 times, most recently
from
1acbaa2 to
1adfbd5
Compare
mrica-equinor
force-pushed
the
redirect-to-asset-page
branch
from
1adfbd5 to
a542486
Compare
| import { config } from 'config' | ||
|
|
||
| export function validateURL() { | ||
| const { installationCode, installationName } = useInstallationContext() |
There was a problem hiding this comment.
Does using contexts inside non-component functions not cause an error/warning in the frontend?
There was a problem hiding this comment.
What i got after redirect:
There was a problem hiding this comment.
Could we rename the function so that it's clear that it will navigate away, and not just validate the inspection?
mrica-equinor
force-pushed
the
redirect-to-asset-page
branch
from
a542486 to
414b8cc
Compare
mrica-equinor
force-pushed
the
redirect-to-asset-page
branch
from
414b8cc to
3a7a86b
Compare
| ` | ||
|
|
||
| export const FrontPage = () => { | ||
| redirectIfNoInstallationSelected() |
There was a problem hiding this comment.
If we wanted to be even more optimal we could useMemo, or a useEffect with empty conditionals here, to prevent this function from needing to be rerun on each render, but it's not too important.
andchiind
left a comment
andchiind
left a comment
There was a problem hiding this comment.
Looks good otherwise. Maybe consider prevent the function from being rerun too often, but otherwise ready to merge.
2 participants
Ready for review checklist: