Skip to content

Introduce tabs and navigation menu#2051

Merged
mrica-equinor merged 1 commit intoequinor:mainfrom
mrica-equinor:update-frontend
Mar 13, 2025
Merged

Introduce tabs and navigation menu#2051
mrica-equinor merged 1 commit intoequinor:mainfrom
mrica-equinor:update-frontend

Conversation

@mrica-equinor
Copy link
Copy Markdown
Contributor

@mrica-equinor mrica-equinor commented Feb 26, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@mrica-equinor mrica-equinor marked this pull request as draft February 26, 2025 12:33
@mrica-equinor mrica-equinor force-pushed the update-frontend branch 4 times, most recently from 4c8700d to 1851152 Compare February 26, 2025 12:45
@mrica-equinor mrica-equinor marked this pull request as ready for review February 26, 2025 12:46
@mrica-equinor mrica-equinor self-assigned this Feb 26, 2025
Eddasol
Eddasol reviewed Mar 3, 2025
View reviewed changes
@Eddasol
Copy link
Copy Markdown
Contributor

Eddasol commented Mar 3, 2025 •
edited by mrica-equinor
Loading

Suggest moving "send to dock"-button so its changed from:
image
to:
image

Eddasol
Eddasol reviewed Mar 3, 2025
View reviewed changes
Eddasol
Eddasol reviewed Mar 3, 2025
View reviewed changes
@mrica-equinor
Copy link
Copy Markdown
Contributor Author

mrica-equinor commented Mar 3, 2025

Suggest moving "send to dock"-button so its changed from: image to: image

This is something i want to do in another PR because it's not straightforward

Eddasol
Eddasol reviewed Mar 3, 2025
View reviewed changes
Eddasol
Eddasol reviewed Mar 11, 2025
View reviewed changes
@mrica-equinor mrica-equinor force-pushed the update-frontend branch 3 times, most recently from 9598bda to f5d98b1 Compare March 12, 2025 14:18
Christdej
Christdej approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrica-equinor mrica-equinor merged commit bea9e8d into equinor:main Mar 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eddasol Eddasol Eddasol left review comments

@Christdej Christdej Christdej approved these changes

Assignees

@mrica-equinor mrica-equinor

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrica-equinor @Eddasol @Christdej