Skip to content

Only cancel current mission outside inspection area#2060

Merged
andchiind merged 2 commits intoequinor:mainfrom
andchiind:2058-do-not-delete-all
Apr 10, 2025
Merged

Only cancel current mission outside inspection area#2060
andchiind merged 2 commits intoequinor:mainfrom
andchiind:2058-do-not-delete-all

Conversation

@andchiind
Copy link
Copy Markdown
Contributor

@andchiind andchiind commented Mar 5, 2025 •
edited
Loading

Closes #2058

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@andchiind andchiind added bug Something isn't working backend Backend related functionality labels Mar 5, 2025
@andchiind andchiind self-assigned this Mar 5, 2025
@andchiind andchiind force-pushed the 2058-do-not-delete-all branch from 44f669c to 3d8b8b8 Compare March 5, 2025 10:34
@andchiind andchiind marked this pull request as draft March 6, 2025 10:36
@aeshub aeshub added the stale This issue or pull request already exists label Apr 6, 2025
@andchiind andchiind force-pushed the 2058-do-not-delete-all branch 2 times, most recently from 876f4c8 to cab2775 Compare April 9, 2025 11:35
@andchiind andchiind marked this pull request as ready for review April 9, 2025 11:36
@aeshub aeshub removed the stale This issue or pull request already exists label Apr 10, 2025
mrica-equinor
mrica-equinor approved these changes Apr 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andchiind andchiind force-pushed the 2058-do-not-delete-all branch from cab2775 to cc327a3 Compare April 10, 2025 10:29
@andchiind andchiind merged commit e5d019e into equinor:main Apr 10, 2025
12 checks passed
@andchiind andchiind deleted the 2058-do-not-delete-all branch April 10, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrica-equinor mrica-equinor mrica-equinor approved these changes

Assignees

@andchiind andchiind

Labels

backend Backend related functionality bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return home not started when last mission was on the wrong inspection area

3 participants

@andchiind @mrica-equinor @aeshub