Skip to content

Add auto schedule button#2146

Merged
mrica-equinor merged 2 commits intoequinor:mainfrom
mrica-equinor:add-schedule-button
Apr 10, 2025
Merged

Add auto schedule button#2146
mrica-equinor merged 2 commits intoequinor:mainfrom
mrica-equinor:add-schedule-button

Conversation

@mrica-equinor
Copy link
Copy Markdown
Contributor

@mrica-equinor mrica-equinor commented Apr 4, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@mrica-equinor
Copy link
Copy Markdown
Contributor Author

mrica-equinor commented Apr 4, 2025

image
image

@mrica-equinor mrica-equinor self-assigned this Apr 4, 2025
@mrica-equinor mrica-equinor added feature New feature or request frontend Frontend related functionality labels Apr 4, 2025
@mrica-equinor mrica-equinor linked an issue Apr 4, 2025 that may be closed by this pull request
Add button for auto scheduling mission #2144
Closed
tsundvoll
tsundvoll reviewed Apr 4, 2025
View reviewed changes
Comment thread frontend/src/language/en.json Outdated
@mrica-equinor mrica-equinor force-pushed the add-schedule-button branch 3 times, most recently from 123f896 to af14dba Compare April 4, 2025 11:56
Christdej
Christdej approved these changes Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andchiind
andchiind reviewed Apr 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. These are just minor details

Comment thread frontend/src/components/Pages/FrontPage/AutoScheduleSection/AutoScheduleSection.tsx Outdated
Comment thread frontend/src/components/Pages/MissionDefinitionPage/MissionDefinitionPage.tsx Outdated
Comment thread frontend/src/components/Pages/MissionDefinitionPage/MissionDefinitionPage.tsx
@mrica-equinor mrica-equinor force-pushed the add-schedule-button branch 5 times, most recently from 779e353 to 0cc7206 Compare April 9, 2025 14:26
@mrica-equinor mrica-equinor merged commit e188f4e into equinor:main Apr 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andchiind andchiind andchiind left review comments

@tsundvoll tsundvoll tsundvoll left review comments

@Christdej Christdej Christdej approved these changes

Assignees

@mrica-equinor mrica-equinor

Labels

feature New feature or request frontend Frontend related functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add button for auto scheduling mission

4 participants

@mrica-equinor @andchiind @tsundvoll @Christdej