Skip to content

Pass string arguments as separate arguments - #2697

Merged
Christdej merged 1 commit into
equinor:mainfrom
Christdej:frontendformatstring
May 6, 2026
Merged

Pass string arguments as separate arguments#2697
Christdej merged 1 commit into
equinor:mainfrom
Christdej:frontendformatstring

Conversation

@Christdej

Copy link
Copy Markdown
Contributor

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Christdej Christdej self-assigned this May 5, 2026
@Christdej
Christdej requested a review from Copilot May 5, 2026 11:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors frontend API error logging to pass message parts to console.error as separate arguments instead of building a single interpolated string. It is a small observability-focused change in the shared API error handler used across the frontend API client.

Changes:

  • Update handleError logging for ApiError instances to use formatted console.error arguments.
  • Update generic error logging to keep the thrown error/object as a separate console argument.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Christdej
Christdej merged commit 6efd6d9 into equinor:main May 6, 2026
12 checks passed
@Christdej
Christdej deleted the frontendformatstring branch May 6, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants