Skip to content

Fix CodeQL security alerts #122 and #123 #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Christdej merged 2 commits into from
May 11, 2026
Merged

Fix CodeQL security alerts #122 and #123 #2705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3374d23
ci: add least-privilege permissions to validate migrations workflow
Christdej May 11, 2026
e45e704
fix: sanitize logged values in AreaPolygonService to prevent log forging
Christdej May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/validate_dotnet_migrations_against_temp_db.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
- 'backend/api/**'
- '.github/workflows/**'

permissions:
contents: read

jobs:
validate_dotnet_migrations_against_temp_db:
uses: equinor/armada/.github/workflows/validate_dotnet_migrations_against_temp_db.yml@main
Expand Down
9 changes: 6 additions & 3 deletions backend/api/Services/AreaPolygonService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Api.Database.Models;
using Api.Utilities;

namespace Api.Services
{
Expand Down Expand Up @@ -40,9 +41,11 @@ public bool MissionTasksAreInsideAreaPolygon(
)
{
logger.LogWarning(
"Robot position {robotPosition} is outside the inspection area polygon for task {taskId}",
robotPosition,
missionTask.Id
"Robot position (X={X}, Y={Y}, Z={Z}) is outside the inspection area polygon for task {taskId}",
robotPosition.X,
robotPosition.Y,
robotPosition.Z,
Sanitize.SanitizeUserInput(missionTask.Id)
);
return false;
}
Expand Down
4 changes: 2 additions & 2 deletions backend/api/Utilities/SanitizeInput.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ namespace Api.Utilities
{
public static class Sanitize
{
public static string SanitizeUserInput(string inputString)
public static string SanitizeUserInput(string? inputString)
{
return inputString.Replace("\n", "").Replace("\r", "");
return inputString?.Replace("\n", "").Replace("\r", "") ?? string.Empty;
}

public static ScheduleMissionQuery SanitizeUserInput(ScheduleMissionQuery inputQuery)
Expand Down
Loading