Refactor alert context to data-driven model - #2830
Open
marianards wants to merge 1 commit into
Open
Conversation
marianards
force-pushed
the
alerts-refactor
branch
from
July 20, 2026 11:34
bc2bde7 to
84f0f84
Compare
marianards
force-pushed
the
alerts-refactor
branch
from
July 20, 2026 11:35
84f0f84 to
d86d1ec
Compare
andchiind
reviewed
Jul 23, 2026
Comment on lines
+18
to
+23
| | { kind: 'failedMissions'; missions: Mission[] } | ||
| | { kind: 'autoScheduleFail'; failedMissions: AutoScheduleFailedMissionDict } | ||
| | { kind: 'dock'; dockType: AlertType } | ||
| | { kind: 'requestFail'; message: string } | ||
| | { kind: 'failure'; title: string; message: string } | ||
| | { kind: 'info'; title: string; message: string } |
Contributor
There was a problem hiding this comment.
Could "kind" be an enum? That would make it easier to refactor and expand in the future.
Contributor
There was a problem hiding this comment.
It would also mean that developers wouldn't need to check the content file to see what options they have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review checklist: