Fix frontend thermal data view - #2891
Merged
nicholasdalhaug merged 3 commits intoAug 19, 2026
Merged
Conversation
nicholasdalhaug
force-pushed
the
fix-frontend-thermal-view
branch
from
August 18, 2026 15:13
8feb815 to
24febe0
Compare
|
🔔 Changes in database files detected 🔔 |
andchiind
approved these changes
Aug 19, 2026
Eddasol
approved these changes
Aug 19, 2026
Eddasol
left a comment
Eddasol
left a comment
Contributor
There was a problem hiding this comment.
Tested and it works well :)
Previous i got this "TaskAnalysisDisplay.tsx:22 React does not recognize the hasFinding prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase hasfinding instead. If you accidentally passed it from a parent component, remove it from the DOM element." in the console and no photo. With this PR I get a photo and no error message
nicholasdalhaug
force-pushed
the
fix-frontend-thermal-view
branch
from
August 19, 2026 10:29
24febe0 to
b416ec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was mainly that the filetype was read wrong. For some reason the sasURLs have parameters after them. We now remove those. Also, we can assume that it is a valid sasURL or throw an error otherwise.
Fixed 2 other small problems.