BUG: Update to new SMDA endpoint#329
Merged
GibranAlfa merged 1 commit intoequinor:mainfrom Mar 24, 2026
Merged
Conversation
slangeveld
reviewed
Mar 24, 2026
| discovery_res = await self._smda.discovery( | ||
| field_identifiers, | ||
| columns=[ | ||
| "field_identifier", |
Collaborator
There was a problem hiding this comment.
Why are these columns removed from the _get_discoveries() method? Is this related to the SMDA "/health" endpoint in any way?
Collaborator
Author
|
I have updated the issue description and PR description |
slangeveld
approved these changes
Mar 24, 2026
Collaborator
slangeveld
left a comment
slangeveld
left a comment
There was a problem hiding this comment.
Looks good now 👍
Health endpoint tested OK using the new availability endpoint in SMDA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #328
Adapt to new SMDA health endpoint (ref here) and their new response model. Have tried testing this from GUI and it works, but maybe you guys can check as well.
The new SMDA backend has:
/availabilityinstead ofactuator/healthprojected_coordinate_systemattribute for the_projectionin/discoveries/searchendpointidentifierattribute for the_projectionin/strat-column-areas/searchendpointChecklist
--cov=src/ --cov-report term-missing)