Skip to content

ENH: Add Model to ProjectConfig - #39

Merged
tnatt merged 1 commit into
equinor:mainfrom
tnatt:add-model-project-config
Aug 14, 2025
Merged

ENH: Add Model to ProjectConfig#39
tnatt merged 1 commit into
equinor:mainfrom
tnatt:add-model-project-config

Conversation

@tnatt

@tnatt tnatt commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Resolves #20

PR to add the model block to the project config, using the Model model from fmu-datamodels.

Checklist

  • Tests added (if not, comment why)
  • Test coverage equal or up from main (run pytest with --cov=src/ --cov-report term-missing)
  • If not squash merging, every commit passes tests
  • Appropriate commit prefix and precise commit message used
  • All debug prints and unnecessary comments removed
  • Docstrings are correct and updated
  • Documentation is updated, if necessary
  • Latest main rebased/merged into branch
  • Added comments on this PR where appropriate to help reviewers
  • Moved issue status on project board
  • Checked the boxes in this checklist ✅

@tnatt
tnatt requested review from joargr and slangeveld August 13, 2025 15:03
@tnatt tnatt self-assigned this Aug 13, 2025

@slangeveld slangeveld left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnatt
tnatt force-pushed the add-model-project-config branch from dd766b5 to deb2398 Compare August 14, 2025 06:20
@tnatt
tnatt force-pushed the add-model-project-config branch from deb2398 to 21da3d9 Compare August 14, 2025 06:22
@tnatt
tnatt merged commit 364e482 into equinor:main Aug 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add model block to config

2 participants