ENH: Add to_rms()/from_rms() methods in NestedHybridGrid - #490
Conversation
27cb4ea to
581762c
Compare
There was a problem hiding this comment.
_make_box_grid_with_region by default create region with id = 2, which means the test below should not create any nested grid. But since the assertion is only checking mock call counts/arguments, this didn't get caught.
There was a problem hiding this comment.
the _make_box_grid_with_region creates a region property where half the values are 1 and half the values are 2... so we are creating a nested grid - just refining the other half than what the target_region_id is saying .. a bit confusing 😄 so will make it more clear and add more test that we do refine the area that has value 1
alifbe
left a comment
There was a problem hiding this comment.
The new class is expecting region value = 1 for nested hybrid grid but the coarse grid is created with region value = 2. But none of the test capture this bug.
Suggest to change test strategy to check if nested grid is created.
Good catch 👀 will update! |
808464a to
b8e19c8
Compare
|
Have a look again @alifbe, I added more checks regarding the actual output itself - not just if expected calls are being made |
There was a problem hiding this comment.
Not related, but this should be list[xtgeo.GridProperty] right?
There was a problem hiding this comment.
yup! will fix it while here
alifbe
left a comment
There was a problem hiding this comment.
This looks great 💯
Just spot something unrelated to this PR. Not sure if it can be part of this PR or another PR.
b8e19c8 to
9f8773c
Compare
Resolves #468
PR that simplifies the initialization of the
NestedHybridGridin RMS, by allowing users to enter names of objects inside RMS instead of xtgeo objects. It also enables easy writing of the grid and all of it's appended properties to RMS.Checklist
--cov=src/ --cov-report term-missing)