Skip to content

chore(deps): Removed deprecated Fusion.ApiClients.Org and update packages #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Jonathanio123
Copy link
Collaborator

@Jonathanio123 Jonathanio123 commented Mar 28, 2025

  • New feature
  • Bug fix
  • High impact

Description of work:

AB#61730

Updated packages and removes the deprecated package Fusion.ApiClients.Org

  • Updated usings to refrence Fusion.Services.Org.ApiModels instead of Fusion.ApiClients.Org.
  • Created a internal IOrgApiClient for use

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

Standard regression testing, looking at logs

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@Jonathanio123 Jonathanio123 changed the title chore(deps): Deprecate Fusion.ApiClients.Org for apis chore(deps): Removed deprecated Fusion.ApiClients.Org Mar 28, 2025
@Jonathanio123 Jonathanio123 marked this pull request as ready for review April 4, 2025 06:42
@Jonathanio123 Jonathanio123 requested a review from Copilot April 7, 2025 08:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 102 out of 107 changed files in this pull request and generated 1 comment.

Files not reviewed (5)
  • src/Fusion.Resources.Functions.Common/Fusion.Resources.Functions.Common.csproj: Language not supported
  • src/Fusion.Summary.Api/Fusion.Summary.Api.csproj: Language not supported
  • src/Fusion.Summary.Functions/Fusion.Summary.Functions.csproj: Language not supported
  • src/backend/Fusion.Resources.Authorization/Fusion.Resources.Authorization.csproj: Language not supported
  • src/backend/Fusion.Resources.Infrastructure/Fusion.Resources.Infrastructure.csproj: Language not supported
Comments suppressed due to low confidence (2)

src/backend/Fusion.Resources.Authorization/Handlers/OrgProjectAccessHandler.cs:63

  • Ensure that omitting the ApiClientMode.Delegate argument does not alter the client configuration required for handling project access. Confirm that the default setup is equivalent to the previous explicit mode.
var client = orgApiClientFactory.CreateClient();

src/backend/Fusion.Resources.Authorization/Handlers/OrgPositionAccessHandler.cs:63

  • Double-check that the removal of the ApiClientMode.Delegate parameter maintains the correct client behavior for position access. Verify the default configuration matches the necessary delegate mode requirements.
var client = orgApiClientFactory.CreateClient();

@Jonathanio123 Jonathanio123 changed the title chore(deps): Removed deprecated Fusion.ApiClients.Org chore(deps): Removed deprecated Fusion.ApiClients.Org and update packages Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant