Skip to content

Conversation

@asbjornhaland
Copy link
Contributor

Why

Why is this change needed?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Additional context

Related issues
closes:
ref:

Checklist

@asbjornhaland asbjornhaland self-assigned this Dec 18, 2025
@asbjornhaland asbjornhaland requested a review from odinr as a code owner December 18, 2025 12:32
Copilot AI review requested due to automatic review settings December 18, 2025 12:32
@asbjornhaland asbjornhaland requested a review from a team as a code owner December 18, 2025 12:32
@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: 30ab3e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@equinor/fusion-framework-module-analytics Patch
@equinor/fusion-framework-module-app Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-cli Patch
portal-analytics Patch
@equinor/fusion-framework-legacy-interopt Patch
poc-portal Patch
@equinor/fusion-framework-cookbook-app-react-ag-grid Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
portal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses missing TypeScript project references in the analytics module's tsconfig.json. The analytics package depends on several workspace packages (@equinor/fusion-framework-module-app, @equinor/fusion-framework-module-context, and @equinor/fusion-framework-react) that were not declared as TypeScript project references, which can affect build order and incremental compilation.

Key changes:

  • Adds three new TypeScript project references to ensure proper build dependencies

@github-actions github-actions bot added 🚧 chore maintaines work, (update deps, workflos ...) 🧬 Modules labels Dec 18, 2025
@asbjornhaland asbjornhaland force-pushed the fix/analytics/add-references-tsconfig branch from 08d3db9 to 13f6aa2 Compare December 18, 2025 12:40
@asbjornhaland asbjornhaland force-pushed the fix/analytics/add-references-tsconfig branch from 13f6aa2 to 30ab3e0 Compare December 18, 2025 12:43
@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.21% 55583 / 1065254
🔵 Statements 5.21% 55583 / 1065254
🔵 Functions 43.56% 559 / 1283
🔵 Branches 62.86% 982 / 1562
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/modules/analytics/src/logExporters/fusionOTLPLogExporter/FusionOTLPLogExporter.ts 0% 100% 100% 0% 3-41
packages/modules/analytics/src/logExporters/fusionOTLPLogExporter/HttpClientExporterTransport.ts 0% 100% 100% 0% 5-89
Generated in workflow #11425 for commit 30ab3e0 by the Vitest Coverage Report Action

@asbjornhaland asbjornhaland merged commit 5114ac4 into main Dec 18, 2025
9 checks passed
@asbjornhaland asbjornhaland deleted the fix/analytics/add-references-tsconfig branch December 18, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚧 chore maintaines work, (update deps, workflos ...) 🧬 Modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants